Add support for spaces in directory names#1
Open
simondeeley wants to merge 2 commits intoLINKIT-Group:masterfrom
simondeeley:master
Open
Add support for spaces in directory names#1simondeeley wants to merge 2 commits intoLINKIT-Group:masterfrom simondeeley:master
simondeeley wants to merge 2 commits intoLINKIT-Group:masterfrom
simondeeley:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes spaces in directory names causes the
PROJECT_NAMEvariable to have spaces in it too. This causes an error during Docker builds as image names cannot have spaces in them. I've added support in the Makefile to correct this by substituting spaces for_(underscores).